Skip to content

upgrade: lifecycle package upgrade for Solid 2.0#889

Open
davedbase wants to merge 2 commits into
solidjs-community:nextfrom
davedbase:update/v2/lifecycle
Open

upgrade: lifecycle package upgrade for Solid 2.0#889
davedbase wants to merge 2 commits into
solidjs-community:nextfrom
davedbase:update/v2/lifecycle

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 10, 2026 •
edited by coderabbitai Bot
Loading

Upgrades @solid-primitives/lifecycle to Solid 2.0 beta.10. All API signatures (createIsMounted, isHydrated, onElementConnect) are unchanged.

Breaking changes for downstream consumers:

  • Peer dependencies now require solid-js@^2.0.0-beta.10 and @solidjs/web@^2.0.0-beta.10
  • Internally: onMount → onSettled, getListener → getObserver, sharedConfig.context → sharedConfig.hydrating, isServer from `@solidjs/web

Summary by CodeRabbit

  • Chores

    • Updated @solid-primitives/lifecycle to require Solid.js v2.0-beta.10 and @solidjs/web v2.0-beta.10 as peer dependencies.
    • Synchronized dev dependencies accordingly.

  • Tests

    • Updated test suite infrastructure to align with Solid.js v2.0 API changes.

Review Change Stack

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 10, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c6040a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase marked this pull request as ready for review May 23, 2026 16:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c7e28386-d383-41f6-8087-27f9419d65b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

solid-2.0

Projects

None yet

Milestone

Solid 2.0 Migration

Development

Successfully merging this pull request may close these issues.

1 participant

@davedbase